LuoYuanke added inline comments.
================ Comment at: clang/lib/CodeGen/TargetInfo.cpp:3417 + llvm::Type *T1 = getFPTypeAtOffset(IRType, IROffset + NextFP, TD); + if (T1 == nullptr) { + if (NextFP == 2) ---------------- Would you add comments on each case like previous code? ================ Comment at: clang/lib/CodeGen/TargetInfo.cpp:3454 - - return llvm::Type::getHalfTy(getVMContext()); - } ---------------- Is this the major change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109607/new/ https://reviews.llvm.org/D109607 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits