Quuxplusone added a comment. I was going to land this just now, but then realized that I've lost the thread of why we're doing most of this. Why are we touching clang/test/SemaCXX/? So I'm going to land just the fixing of the curly braces in libcxxabi/src/.
================ Comment at: libcxxabi/src/cxa_exception_storage.cpp:99 + abort_message("execute once failure in __cxa_get_globals_fast()"); + // static int init = construct_(); + return static_cast<__cxa_eh_globals *>(std::__libcpp_tls_get(key_)); ---------------- This commented-out line confuses me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109408/new/ https://reviews.llvm.org/D109408 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits