Quuxplusone added a comment. In D109411#2990494 <https://reviews.llvm.org/D109411#2990494>, @dblaikie wrote:
> Looks like most of the testing for the enable_if custom dialog was added in > `clang/test/SemaTemplate/overload-candidates.cpp` in > rG6f8d2c6c9c3451effdf075a7034bbe77045bfeba > <https://reviews.llvm.org/rG6f8d2c6c9c3451effdf075a7034bbe77045bfeba>. > (improved in rG00fa10b43f25d98e88cc81b653dfe8d49327722d > <https://reviews.llvm.org/rG00fa10b43f25d98e88cc81b653dfe8d49327722d> - > though no substantially novel test coverage added, just updating the improved > diagnostic text) - maybe pull that test coverage over into this new dedicated > test file? But no big deal. Yeah, I noticed those changed-but-not-really-added tests over there. I did deliberately make a new file because I wanted it to explicitly test alias templates like `enable_if_t`, whereas `overload-candidates.cpp` runs in C++98 and thus cannot contain alias templates. I don't know if the existing tests are adding super much value, but I don't think it would add any //more// value to pull them over into this new file (in fact we'd have to stop running them in C++98 mode), and I'm not confident enough that they add //zero// value to go entirely remove them. So, status quo is I just left them alone. Anyone particularly want to jump in here? because otherwise I think I'll land this tomorrow-ish. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109411/new/ https://reviews.llvm.org/D109411 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
