aaron.ballman added a comment.

Is this syntax used by any other tools?



================
Comment at: 
clang-tools-extra/test/clang-tidy/infrastructure/nolintbeginend.cpp:6
+
+// NOLINTEND
+class B1 { B1(int i); };
----------------
Do you think this should be diagnosed as a sign of user confusion with the 
markings?


================
Comment at: 
clang-tools-extra/test/clang-tidy/infrastructure/nolintbeginend.cpp:86
+
+// NOLINTBEGIN
+class H1 { H1(int i); };
----------------
Should this be diagnosed as user confusion?

My concern in both of these cases isn't so much that someone writes this 
intentionally, but that one of the begin/end pair gets removed accidentally 
when refactoring. Helping the user to identify *where* the unmatched delimiters 
are seems like it could be user-friendly behavior.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108560/new/

https://reviews.llvm.org/D108560

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to