lei added inline comments.
================
Comment at: clang/test/CodeGen/builtins-ppc-int128.c:4
+// RUN: -triple powerpc64-unknown-unknown -target-cpu pwr8 \
+// RUN: -emit-llvm %s -o - -U__XL_COMPAT_ALTIVEC__ | FileCheck %s
+// RUN: %clang_cc1 -target-feature +altivec -target-feature +vsx \
----------------
NeHuang wrote:
> nit: indentation
thx. Will fix before comit.
================
Comment at: clang/test/Parser/altivec.c:92
// These should have errors.
+#ifndef __VSX__
__vector double vv_d1; // expected-error {{use of 'double' with
'__vector' requires VSX support to be enabled (available on POWER7 or later)}}
----------------
NeHuang wrote:
> Will this patch also impact `vector double`? If not, can we move `#ifndef
> __VSX__` down below `vector double v_d2;`?
This patch doesn't, but this is needed here since I added RUN line to test
behavior for when VSX is enabled. Note the test lines was not changed for
`vector double`.
================
Comment at: clang/test/Parser/cxx-altivec.cpp:91
-// These should have errors.
+#ifndef __VSX__
+// These should have errors for non pwr7 vsx builds.
----------------
NeHuang wrote:
> same as above.
needed due to new RUN line added.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109178/new/
https://reviews.llvm.org/D109178
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
