sherwin-dc added a comment.

I have changed the unroll and icp tests to instead look at the passes that were 
run, which are shown with the `-mllvm -opt-bisect-limit=-1` flag. This should 
allow checking that the Loop Unrolling and Indirect Call Promotion passes are 
run with samplepgo but not thinlto.

To clarify, the backend that I am working on does not disable the Loop 
Unrolling pass from running, but uses target hooks within the pass to stop the 
loop from being unrolled, hence this would work for targets that would choose 
to disable loop unrolling in this way.

The bottom 2 tests are combined together now because of the way the passes are 
printed out. Though if there is a better way of arranging the tests please let 
me know. For reference this is what the output looks like:

F18895609: thinlto.txt <https://reviews.llvm.org/F18895609>

F18895608: samplepgo.txt <https://reviews.llvm.org/F18895608>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109234/new/

https://reviews.llvm.org/D109234

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to