Topotuna added a comment. Overall, I think the release notes accurately describe tasks I have been working on. A couple of suggestions and minor grammatical changes provided.
================ Comment at: clang/docs/ReleaseNotes.rst:159 + +- All builtin types, macros and functions declarations are now added by default + without any command-line flags. A flag is provided ``-cl-no-stdinc`` to ---------------- `function declarations` - first word in singular form ================ Comment at: clang/docs/ReleaseNotes.rst:168 + C++ for OpenCL. + +Misc common changes: ---------------- Would it be worth mentioning that command line flag `-cl-std=clc++1.0` is now allowed and preferred over `-cl-std=clc++`? ================ Comment at: clang/docs/ReleaseNotes.rst:174 + +- Fix OpenCL C language version and SPIR address space reporting in DWARF. + ---------------- `Fixed OpenCL C language version ...` - past form of "fix" for consistency with other bullet points ================ Comment at: clang/docs/ReleaseNotes.rst:194 + +- ``cl_khr_integer_dot_product`` for dedicated support of DOT product. + ---------------- Is there a reason why `DOT` is written in all capitals? If yes, then maybe it should be written like so in `Arm dot product extension` on line 177 as well? ================ Comment at: clang/docs/ReleaseNotes.rst:218 + +- Added ``NULL`` macro to internal headers. + ---------------- I think this should be rephrased. NULL macro was already present in internal headers but now its value is redefined to `nullptr`. I would suggest listing it as: ``` - Redefined ``NULL`` macro in internal headers to be compatible with C++. ``` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109327/new/ https://reviews.llvm.org/D109327 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
