[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

[Jon Chesterfield via Phabricator via cfe-commits]

JonChesterfield added inline comments.


================
Comment at: clang/lib/Headers/openmp_wrappers/complex:48
+#ifdef __NVPTX__
 #pragma omp begin declare variant match(                                       
\
     device = {arch(nvptx, nvptx64)},                                           
\
----------------
Is the ifdef nvptx necessary? I thought the bug with variant only affected 
amdgpu. Looks like it might be an artifact of using a single end declare for 
both architectures

Also possible that adding amdgcn to the arch list by nvptx64 will work here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109344/new/

https://reviews.llvm.org/D109344

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits