jdenny added a comment. In D109255#2983063 <https://reviews.llvm.org/D109255#2983063>, @jsji wrote:
> In D109255#2983052 <https://reviews.llvm.org/D109255#2983052>, @ABataev wrote: > >> In D109255#2983017 <https://reviews.llvm.org/D109255#2983017>, @jdenny wrote: >> >>> This test is meant to check that the driver processes these options >>> correctly. -cc1 isn't the driver and often ignores either the positive or >>> negative version of an option. >> >> Better not to do such checks, just need to check that driver correctly >> translates driver options to the frontend options (using `-###`), better to >> use `-verify` only with the frontend tests. Suggest to rework this test. > > Make sense to me. How about we use `_cc1` as Alexey suggested here (and > rename the file to remove `driver-` prefix). OK. > Maybe Joel can add another test to test the driver correctly translates > driver options to the frontend options (using `-###`) in `test/Driver` dir? I probably won't get to it today, but I can work on it later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://reviews.llvm.org/D109255 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits