aaron.ballman added inline comments.
================
Comment at:
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-member-init.cpp:526
+ union {
+ int K;
+ };
----------------
Can you add a `CHECK-FIXES-NOT` that we're not adding the fix for this case?
================
Comment at:
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-member-init.cpp:529
+ union {
+ int Z;
+ int Y;
----------------
Same here.
================
Comment at:
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-member-init.cpp:534
+
+union U2 {
+ U2() {}
----------------
A related interesting test would be:
```
union U3 {
U3() {}
struct {
int B;
} b;
int A;
};
```
I would expect `A` or `b` to need initialization for the union, and `B` to need
initialization for the struct.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108370/new/
https://reviews.llvm.org/D108370
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
