tra added a comment.

In D108787#2968503 <https://reviews.llvm.org/D108787#2968503>, @yaxunl wrote:

> need a test for non-template static member function as kernel. also need 
> codegen tests.

I've added more tests for different code paths leading to the kernel call. 
Interestingly enough, only the a0 actually calls `BuildCallToMemberFunction`. 
Other variants go through different code paths that handle the call without it.

As for the codegen, all kernel calls that make it to 
`clang::Sema::BuildResolvedCallExpr` with launch config are handled the same 
way. I don't think codegen tests will buy us much.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108787/new/

https://reviews.llvm.org/D108787

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to