lebedev.ri added a comment.

In D108826#2969547 <https://reviews.llvm.org/D108826#2969547>, @ABataev wrote:

> In D108826#2969471 <https://reviews.llvm.org/D108826#2969471>, @lebedev.ri 
> wrote:
>
>> I think there is something really wrong with vectorzer passes in LTO 
>> pipelines.
>> Can you say whether the problem you are observing is in ThinLTO, Full LTO, 
>> or both?
>
> I saw it in Full LTO but suppose we have a similar problem in ThinLTO. SLP 
> vectorizer at compile-time tries to vectorize using small vectors at it may 
> affect other optimizations at link time (e.g. after inlining we may try to 
> vectorize using large vector sizes etc.). This is just a preliminary attempt 
> to see how can we fix this early optimization in SLP.

Aha, so full lto. That is consistent with the phase ordering dilemma @spatel 
discovered: D102002 <https://reviews.llvm.org/D102002>
IMO workarounding it in the pass isn't the right course of action. Such 
workarounds tend to stick around.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108826/new/

https://reviews.llvm.org/D108826

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to