amyk added a comment.
Please update the patch with full context.
================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp:1546
+ // into a select.
+ if (Register::isPhysicalRegister(Cond[1].getReg())) {
+ return false;
----------------
nit: `uses a physical register`
================
Comment at: llvm/test/CodeGen/PowerPC/ifcvt_cr_field.ll:3
+; RUN: llc < %s -mtriple=powerpc64-unknown-linux-gnu -mcpu=pwr7
-verify-machineinstrs | FileCheck %s
+target datalayout =
"E-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-f128:128:128-v128:128:128-n32:64"
+target triple = "powerpc64-unknown-linux-gnu"
----------------
Are the `target datalayout` and `target triple` necessary?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108302/new/
https://reviews.llvm.org/D108302
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
