sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
LG with the understanding that we'll have to move this to be more sophisticated
later later, but it's useful to have the simple version now.
Similarly I think it's OK to add the tests later too as this version is
experimental & safe.
================
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:180
+ if (Opts.IndexStandardLibrary) {
+ StandardLibraryIdx = indexStandardLibrary(TFS);
+ if (!StandardLibraryIdx) {
----------------
add a FIXME that this happens synchronously, and can't respond to langopts or
config and I think we're good to go as an experimental feature
================
Comment at: clang-tools-extra/clangd/ClangdServer.h:412
+ // If present, the index of the standard library.
+ std::unique_ptr<SymbolIndex> StandardLibraryIdx;
----------------
You can push this into MergedIdx for storage. The reason for DynamicIdx and
BackgroundIdx having dedicated variables is that they have special APIs we need
to access.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108119/new/
https://reviews.llvm.org/D108119
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
