bkramer added inline comments.

================
Comment at: include-fixer/find-all-symbols/tool/STLPostfixHeaderMap.cpp:15
@@ +14,3 @@
+
+const HeaderMapCollector::HeaderMap STLPostfixHeaderMap = {
+    {"include/__stddef_max_align_t.h", "<cstddef>"},
----------------
I wonder if it's worth lazy-initializing this map with ManagedStatic or 
something, having a global with ctor&dtor isn't pretty.

================
Comment at: include-fixer/find-all-symbols/tool/STLPostfixHeaderMap.cpp:20
@@ +19,3 @@
+    {"include/adxintrin.h", "<immintrin.h>"},
+    {"include/ammintrin.h", "<random>"},
+    {"include/avx2intrin.h", "<immintrin.h>"},
----------------
random

================
Comment at: include-fixer/find-all-symbols/tool/STLPostfixHeaderMap.cpp:82
@@ +81,3 @@
+    {"include/asm-generic/errno.h", "<cerrno>"},
+    {"/usr/include/assert.h", "<cassert>"},
+    {"algorithm", "<algorithm>"},
----------------
Why is assert.h special?


http://reviews.llvm.org/D20566



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to