JonChesterfield added a comment.

Tests. The usual bug in this area is that an archive can contain multiple files 
with the same name which clobber each other if extracted to the same directory. 
It looks to me like this implementation will fail that test.

Also, motivation? Seems this can be worked around by not putting cubin files in 
an archive.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108291/new/

https://reviews.llvm.org/D108291

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to