Anastasia requested changes to this revision. Anastasia added a comment. This revision now requires changes to proceed.
In D108113#2949173 <https://reviews.llvm.org/D108113#2949173>, @svenvh wrote: > In D108113#2949141 <https://reviews.llvm.org/D108113#2949141>, @Anastasia > wrote: > >> @svenvh I would like to discuss it further with Sven whether it is a good >> direction or not? > > The underlying motivation for adding those aliases seems to be missing from > the description. > > Personally, I do not see the point of adding aliases to save two characters > (you only save the "20" part of "clc++2021"), while adding potential > confusion ("is the language called //C++ for OpenCL 2021// or //C++ for > OpenCL 21//, or maybe it has something to do with //OpenCL 2.1//?"). Also > they are being added as deprecated aliases, suggesting they might be removed > at some point in the future again? > > I'd much rather see one canonical way of specifying the language version, > instead of adding multiple aliases to do the same thing. But perhaps there > is a good reason that I am not aware of? The main motivation for this was just a shorter spelling. Ok, it seems like there is some trade off... so let's hold off this change for now until we either get more input that shows some clear benefit or shows that there is none and then we can abandon the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108113/new/ https://reviews.llvm.org/D108113 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
