craig.topper added inline comments.
================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3197
+ else if (PatchedName.endswith("sh"))
+ PatchedName = IsVCMP ? "vcmpsh" : "cmpsh";
+ else if (PatchedName.endswith("ph"))
----------------
pengfei wrote:
> LuoYuanke wrote:
> > There is no cmpsh?
> Good catch!
Changing this created bug where this is now accepted
cmpeqsh %xmm0, %xmm1, %k1
================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86ATTInstPrinter.cpp:169
+ case X86::VCMPPHZrrib: case X86::VCMPPHZrribk:
+ case X86::VCMPSHZrrb_Int: case X86::VCMPSHZrrb_Intk:
if (Imm >= 0 && Imm <= 31) {
----------------
What about the equivalent code in the Intel printer?
================
Comment at: llvm/lib/Target/X86/X86InstrAVX512.td:2670
+let Predicates = [HasFP16] in {
+ def : Pat<(v1i1 (X86cmpms(loadf16 addr:$src2), FR16X:$src1,
CommutableCMPCC:$cc)),
+ (VCMPSHZrm FR16X:$src1, addr:$src2, imm:$cc)>;
----------------
This should be synchronized with the CMPSS/CMPSD code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105264/new/
https://reviews.llvm.org/D105264
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
