aaron.ballman added inline comments.
================
Comment at: clang/lib/Lex/Lexer.cpp:1444
+ static const llvm::sys::UnicodeCharSet XIDContinueChars(XIDContinueRanges);
+ return C == '_' || XIDStartChars.contains(C) ||
+ XIDContinueChars.contains(C);
----------------
Is looking at start chars correct? I was thinking this should only look at the
continuation characters because `isAllowedInitiallyIDChar` handles the start of
an identifier.
================
Comment at: clang/test/CXX/drs/dr2xx.cpp:600
-namespace dr248 { // dr248: yes c++11
- // FIXME: Should this also apply to c++98 mode? This was a DR against C++98.
----------------
This means we're going to drop our support of this DR on
https://clang.llvm.org/cxx_dr_status.html when that page gets regenerated. What
should our status of that DR be with these changes?
================
Comment at: clang/test/CXX/drs/dr6xx.cpp:721
-namespace dr663 { // dr663: yes c++11
- int ЍЎ = 123;
----------------
Same concern here as above.
================
Comment at: clang/test/Lexer/unicode.c:40-43
+extern int 👷♀; // expected-warning {{declaration does not declare anything}}
+//expected-error@-1 {{character <U+1F477> not allowed in identifier}}
+//expected-error@-2 {{character <U+200D> not allowed in identifier}}
+//expected-error@-3 {{character <U+2640> not allowed in identifier}}
----------------
Then we don't have to do line number math to see what line the diagnostics are
attached to. :-)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104975/new/
https://reviews.llvm.org/D104975
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
