cor3ntin marked an inline comment as done.
cor3ntin added inline comments.

================
Comment at: clang/test/CodeGen/string-literal-short-wstring.c:17
   // MSABI: linkonce_odr dso_local unnamed_addr constant [3 x i16] [i16 65, 
i16 66, i16 0]
-  const wchar_t *foo = L"AB";
+  const unsigned short *foo = L"AB";
 
----------------
aaron.ballman wrote:
> I'd feel most comfortable if the top of the file did:
> ```
> typedef __WCHAR_TYPE__ wchar_t;
> ```
> as that's the definition of `wchar_t` from the `stddef.h` provided by Clang.
Thanks, I was looking for exactly that


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106215/new/

https://reviews.llvm.org/D106215

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to