vsapsai added a comment. Why are you not just changing `return OutOfDate` to `return Failure` for SUBMODULE_UMBRELLA_HEADER and SUBMODULE_UMBRELLA_DIR? I have no strong opinion on this but it feels more in line with the rest of the changes. Also I've tried to do that and nothing seems to be broken.
And for the rest of the code for these records I think it is worth keeping `ModMap.setUmbrellaHeader` and `ModMap.setUmbrellaDir` with preceding preparation and checks. The code in ModuleMap seems to be complicated enough and stateful, so removing those setters can break some stuff. It is possible everything will be fine but I don't want to chance that unless required. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107690/new/ https://reviews.llvm.org/D107690 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
