Anastasia added a comment.

Great! Thanks!

The suggested minor test clean-up can be addressed in the final commit!



================
Comment at: clang/test/SemaOpenCL/nosvm.cl:10
+// expected-warning@-2 {{'nosvm' attribute is deprecated and ignored in OpenCL 
C version 2.0}}
+#elif defined(CLCPP10)
+// expected-warning@-4 {{'nosvm' attribute is deprecated and ignored in C++ 
for OpenCL version 1.0}}
----------------
Here we could check for predefined macros `__OPENCL_CPP_VERSION `instead


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107648/new/

https://reviews.llvm.org/D107648

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D107648: [OpenCL... Anastasia Stulova via Phabricator via cfe-commits

Reply via email to