benshi001 added a comment. In D107682#2936040 <https://reviews.llvm.org/D107682#2936040>, @MaskRay wrote:
> Seems a new RUN line is needed. If having too many mock trees are > inconvenient, consider `clang/unittests/Driver/ToolChainTest.cpp` I am not familiar with the way in `clang/unittests/Driver/ToolChainTest.cpp`, I always use clang command line than libcall. Though I have created a new test `TEST(ToolChainTest, VFSAVRInstallation)` by imitating the existing `TEST(ToolChainTest, VFSGCCInstallation)`, it did not work as I expected. So I created a new mock tree `basic_avr_tree_2`. And the tests in avr-toolchain.cc should cover all three possible cases 1. find avr-libc at AVR-GCC/../../../avr (the case `--check-prefix=CHECK1`) 2. find avr-libc at AVR-GCC/../../../../avr (the case `--check-prefix=CHECK2`) 3. there is not avr-gcc and find avr-libc at SYSROOT/usr/avr (the case `--check-prefix=CHECK3`) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107682/new/ https://reviews.llvm.org/D107682 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
