wenlei accepted this revision. wenlei added a comment. This revision is now accepted and ready to land.
lgtm, thanks. ================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3896 - // These two forms of profiling info can't be used together. - if (const Arg *A1 = Args.getLastArg(options::OPT_fpseudo_probe_for_profiling)) - if (const Arg *A2 = Args.getLastArg(options::OPT_fdebug_info_for_profiling)) ---------------- hoy wrote: > wenlei wrote: > > Would a warning be useful to catch accidental misuse? > I was thinking about that. It may be useful, but downstream may have to > suppress that warning to be treated as error for a clean build. What do you > think? Fair point. We could add warning after transition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107876/new/ https://reviews.llvm.org/D107876 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
