aaron.ballman added a comment.
Thank you for working on this, I think it's fantastic functionality!
================
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4357
+ continue;
+ llvm::StringRef Name = S.NormalizedFullName;
+ if (Completion == AttributeCompletion::Scope) {
----------------
Should we also add some special handling for attributes optionally starting
with double underscores? e.g., `__attribute__((const))` and
`__attribute__((__const__))`` are both equally useful to complete.
Also, we should add some explicit testing for `omp::sequence` and
`omp::directive` as those are handled very specially and won't appear in the
parsed attribute map. I think the OpenMP code completion would be super useful,
but can be handled in a follow-up if you want.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107696/new/
https://reviews.llvm.org/D107696
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
