rampitec added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12120
+ OptimizationRemarkEmitter *ORE,
+ OptimizationRemark OptRemark) {
+ ORE->emit([&]() { return OptRemark; });
----------------
gandhi21299 wrote:
> rampitec wrote:
> > gandhi21299 wrote:
> > > rampitec wrote:
> > > > Why OptRemark and not just StringRef? I really want to see as little
> > > > churn as possible at the call site.
> > > With only StringRef, we would also have to pass in RMW since
> > > OptimizationRemark constructor depends on that.
> > It seems better be a lamda where you can just capture most of the stuff.
> What would the type be for the following lambda?
>
> ```
> [&](){
> return OptimizationRemark(...);
> }
> ```
You need to return TargetLowering::AtomicExpansionKind, not OptimizationRemark.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106891/new/
https://reviews.llvm.org/D106891
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
