rampitec added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12118
-TargetLowering::AtomicExpansionKind
-SITargetLowering::shouldExpandAtomicRMWInIR(AtomicRMWInst *RMW) const {
+TargetLowering::AtomicExpansionKind SITargetLowering::reportAtomicExpand(
+ AtomicRMWInst *RMW, TargetLowering::AtomicExpansionKind Kind,
----------------
Just static, no need to expose it from SITargetLowering. Maybe even a functor
inside shouldExpandAtomicRMWInIR ifself capturing ORE and RMW to pass less
arguments.
================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12165
- return AtomicExpansionKind::None;
+ ORE->emit([&] {
+ OptimizationRemark Remark(DEBUG_TYPE, "Passed", RMW->getFunction());
----------------
You need to remove all of that now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106891/new/
https://reviews.llvm.org/D106891
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
