jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land.
In D105881#2926523 <https://reviews.llvm.org/D105881#2926523>, @awarzynski wrote: > Yes. Updating printHelp > <https://github.com/llvm/llvm-project/blob/main/llvm/lib/Option/OptTable.cpp#L575> > wouldn't be too difficult. Would you be in favor? Yes, I think that would make stuff a bit easier to understand. > I've experimented with a few more approaches and feel that the cleanest > approach would be to: > > - rename `OptOutFFlag`/`OptInFFlag` as `OptOutCC1FFlag` and `OptInCC1FFlag` > - introduce `OptOutFC1FFlag` and `OptInFC1FFlag`. > > We will end-up with a bit of duplication in Options.td, but the long term > goal is to split it into multiple files anyway. Also, I think that in this > case code re-use would lead to a rather convoluted implementation. I'm will > send an updated patch shortly. That sounds good to me. Thanks for seeing this through! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105881/new/ https://reviews.llvm.org/D105881 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
