dexonsmith added a comment.

In D106862#2913815 <https://reviews.llvm.org/D106862#2913815>, @arphaman wrote:

> I think this approach makes sense for now. It's unfortunate that the 
> constructor of FullSourceLoc is unable to validate this requirement, do you 
> know how many clients that you describe as modifying their ID to make them 
> valid are there?

(Maybe an `Optional<FullSourceLoc>` would work for those clients?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106862/new/

https://reviews.llvm.org/D106862

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to