guitard0g added a comment. @vsavchenko
> I see that the "applies to pointer arguments only" warning is not tested for > `noescape`, but I still find it to be a good practice to write a test with a > bunch of cases with attributes applied in wrong places. Updated with some tests for this! > Additionally, I believe that `escape` and `noescape` convey the same > information, and it is totally okay to have two attributes because the user > has to have a choice to say either "I do escape it" or "I definitely do not > escape it" when the default is unspecified at all. But I do think that we > should add a check disallowing both of these attributes to be used at the > same time for the same parameter, since they directly contradict one another. Ah that's a great point, most recent update makes these two mutually exclusive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107026/new/ https://reviews.llvm.org/D107026 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
