MaskRay added a comment. If you upload a diff via "Upload Diff" on webUI or `arc diff 'HEAD^'`, by default the subject/summary are not updated.
After editing your local commit message, please update the review as well to be synchronized. The patch changed the signature of `FunctionDecl::Create`. When changing clang/include/clang headers, it's a good idea to test `check-lldb check-clang-tools` (`-DLLVM_ENABLE_PROJECTS='...;clang-tools-extra;lldb'` in case clang-tools-extra/ and lldb/ have code needing updates. In this case there was an lldb build failure I just fixed. I assume that passing false (`/*UsesFPIntrin=*/false`) is safe. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102343/new/ https://reviews.llvm.org/D102343 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
