cjdb added inline comments.
================ Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:307 +def err_pragma_include_instead_system_reserved : Error< + "header '%0' is an implementation detail; #include %select{'%2'|either '%2' or '%3'|one of %2}1 instead">; + ---------------- aaron.ballman wrote: > 80-col wrapping. Surprised this made it past the first time. ================ Comment at: clang/test/PCH/ms-pch-macro-include_instead-regression.c:2 +// Enabling MS extensions should allow us to add BAR definitions. +// RUN: %clang_cc1 -DMSEXT -fms-extensions -DBAZ=\"Inputs/pch-through1.h\" -emit-pch -o %t1.pch +// RUN: %clang_cc1 -DMSEXT -fms-extensions -include-pch %t1.pch -verify %s ---------------- aaron.ballman wrote: > This fixes the shell issue when I try it out locally on Windows. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106898/new/ https://reviews.llvm.org/D106898 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits