aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM! ================ Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:304 + +def pp_pragma_include_instead_not_sysheader : Error< + "'#pragma clang include_instead' cannot be used outside of system headers">, ---------------- cjdb wrote: > aaron.ballman wrote: > > Can you prefix the diagnostic identifiers with `err_`? We're not super > > consistent in this file, but it's helpful when reading the use of the > > diagnostic to know whether it's an error or not. > I've replaced `pp` with `err` since `pragma` implies "preprocessor" and don't > really think it adds much more value. `err` on the other hand is useful? SGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106394/new/ https://reviews.llvm.org/D106394 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
