MarcusJohnson91 marked 3 inline comments as done.
MarcusJohnson91 added inline comments.
================
Comment at: llvm/lib/Support/ConvertUTFWrapper.cpp:168
+ std::vector<UTF32> ByteSwapped;
+ if (Src[0] == UNI_UTF16_BYTE_ORDER_MARK_SWAPPED) {
+ ByteSwapped.insert(ByteSwapped.end(), Src, SrcEnd);
----------------
efriedma wrote:
> Wrong constant.
>
> Is this really the function you want to be using from clang? I don't really
> understand why you'd want to handle byte order marks.
I don't really care about the BOM tbh, I just figured if I was in here, I
should flesh out the UTF-32 interface.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106753/new/
https://reviews.llvm.org/D106753
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
