MaskRay added inline comments.
================
Comment at: clang/test/LibClang/lit.local.cfg:1
+
+config.substitutions.append(('%libclang', os.path.join(config.clang_lib_dir,
'libclang.so')))
----------------
delete blank line
================
Comment at: clang/test/LibClang/symbols.test:2
+# Check that there are no unversioned clang symbols in libclang.so
+RUN: llvm-nm -Dj --defined-only %libclang | grep -v -e '@@LLVM_[0-9]\+$' | not
grep '^clang'
----------------
Also a test that no local symbol is called `clang_*`
A `local: *` can easily localize unintented `clang_*` symbols
================
Comment at: clang/tools/libclang/libclang.map:405
+ clang_visitChildrenWithBlock;
+local: *;
+};
----------------
MaskRay wrote:
> Make its indentation match `global:`
You may consider
```
LLVM_13 {
/* no global: here */
clang_foobar;
}
local {
local: *;
}
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105527/new/
https://reviews.llvm.org/D105527
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
