dgoldman added a comment.
Removed the TextMarks file, just need to swap over how the insertions are done
================
Comment at: clang-tools-extra/clangd/TextMarks.h:45
+ : SM(SM), Out(Out) {}
+ void PragmaMark(SourceLocation Loc, StringRef Trivia) override {
+ if (isInsideMainFile(Loc, SM)) {
----------------
sammccall wrote:
> please avoid puttng bodies inline unless trivial or hot
Ah CollectMacros has lots of stuff inline, so I mirrored that, doesn't look
like many other file do that though
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105904/new/
https://reviews.llvm.org/D105904
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
