[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

[Zakk Chen via Phabricator via cfe-commits]

khchen added a comment.

This all looks good to me except some tidy warning.
wait for others comments.



================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:460
+
+    addExtension("e");
+  }
----------------
nit: add `break;` to avoid the implicit-fallthrough warning.


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:57
+}
+
 namespace {
----------------
nit: please fix this tidy warning


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105168/new/

https://reviews.llvm.org/D105168

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits