vitalybuka added inline comments.
================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:427
+ bool DisableOptimization) {
assert(!CompileKernel || Recover);
+ return new HWAddressSanitizerLegacyPass(CompileKernel, Recover,
----------------
eugenis wrote:
> vitalybuka wrote:
> > @eugenis unrelated to the patch, but why do we this args if then we
> > assert(!CompileKernel || Recover);
> why not? This forbids CompileKernel && !Recover, how else would you represent
> the 3 remaining combinations?
> why not? This forbids CompileKernel && !Recover, how else would you represent
> the 3 remaining combinations?
Thanks. I've misread the expression.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105703/new/
https://reviews.llvm.org/D105703
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
