[PATCH] D106146: [clang][deps] Separate filesystem caches for minimized and original files

[Duncan P. N. Exon Smith via Phabricator via cfe-commits]

dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: 
clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:165
 
-  if (const CachedFileSystemEntry *Entry = getCachedEntry(Filename)) {
+  bool Minimize = !IgnoredFiles.count(Filename) && shouldMinimize(Filename);
+
----------------
Nit: I suggest calling this `ShouldMinimize`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106146/new/

https://reviews.llvm.org/D106146

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits