glaubitz added a comment.

In D100148#2880499 <https://reviews.llvm.org/D100148#2880499>, @hvdijk wrote:

> Updated to use `Triple.isX32()`.
>
> Should we perhaps just merge this as is, ahead of the update to compiler-rt 
> to create x32 objects? For non-x32, this change is NFC, for x32, the change 
> results in a better error message about compiler-rt objects not existing 
> rather than being for the wrong architecture.

Yes, I fully agree on this stance. I've been waiting for this patch for Debian, 
plus the remaining changes to get Rust to build on x32 ;-).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100148/new/

https://reviews.llvm.org/D100148

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D100148:... Harald van Dijk via Phabricator via cfe-commits
    • [PATCH] D10... John Paul Adrian Glaubitz via Phabricator via cfe-commits
    • [PATCH] D10... Harald van Dijk via Phabricator via cfe-commits
    • [PATCH] D10... Fangrui Song via Phabricator via cfe-commits
    • [PATCH] D10... John Paul Adrian Glaubitz via Phabricator via cfe-commits

Reply via email to