dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land.
Could probably haggle over the tests some more, but might be diminishing returns at this point. Looks good! Might suggest separating the code cleanup mlir changes from the warning change (committing the warning change first, then as a follow-up committing the mlir change), ideally. Not a huge deal either way - but the usual "separable changes should be separated". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102728/new/ https://reviews.llvm.org/D102728 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
