NeHuang added inline comments.
================ Comment at: clang/lib/Sema/SemaChecking.cpp:3356 + case PPC::BI__builtin_ppc_maddld: + return SemaFeatureCheck(*this, TheCall, "power9-vector", + diag::err_ppc_builtin_only_on_pwr9); ---------------- amyk wrote: > This is just a question. > Is `power9-vector` the correct feature check in these cases? Does it matter > if these are not vector instructions? yeah, we planned using this feature to do the sema check for `pwr9` only (or later cpus) builtins. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102875/new/ https://reviews.llvm.org/D102875 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
