Szelethus added a comment. In D105552#2861924 <https://reviews.llvm.org/D105552#2861924>, @vsavchenko wrote:
> Sorry about being pretty harsh here. I do think that `NoStoreFuncVisitor` > needs refactoring and better abstractions, I just don't think that this is > the way to go. Nah, you're totally right. In retrospect, this refactoring feela a lot like it was done by a robot, not a human. It was a part of some greater plan that I abandoned later, so its luckily not a consequential change to my overall refactoring efforts. Cheers for the enlightening! I suppose I never saw similar changed that way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105552/new/ https://reviews.llvm.org/D105552 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
