amyk added inline comments.
================ Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-error.c:11 + +long long lla, llb; +int ia, ib; ---------------- nit: Have these variables as `extern` like the other patches do. ================ Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-trap.c:14 + +long long lla, llb; +double da; ---------------- nit: Have these variables as `extern` like the other patches do. ================ Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:2233 +def : InstAlias<"tdlle $rA, $rB", (TD 6, g8rc:$rA, g8rc:$rB)>; +def : InstAlias<"tdlge $rA, $rB", (TD 5, g8rc:$rA, g8rc:$rB)>; ---------------- Are `tdne`, `tweq` supposed to be aliases that are intended to be added here, too? ================ Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:2840 + +// XL Compatibility +// twne ---------------- Question: Why are these in `PPCInstrPrefix.td`? Shouldn't they be in `PPCInstrInfo.td` instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103668/new/ https://reviews.llvm.org/D103668 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
