RedDocMD marked 4 inline comments as done. RedDocMD added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:316 + +class OperatorKind { + union { ---------------- NoQ wrote: > One good place to put this may be `CheckerHelpers.h`. This is where we dump > all the stuff that's probably useful in multiple checkers but not in other > places. > > I also wonder if you plan to support unary operators. The interesting part > about them is that they are sometimes ambiguous to binary operators in their > string representation, eg. `-`. I guess passing a parameter to chose operator arity should work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D104616 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits