MyDeveloperDay added a comment.

> is a smell that tells us to use an enum.

I totally agree

> Personally I find it harder to finder multiple options that concern the same 
> aspect of the code style rather than a single option.

To be honest, I think we know the options some of the best (apart of course 
from @djasper and @klimek), and most of the time I'm totally confused, as to 
which options do which, it ends up being trail and error. This way bugs creep 
in.

Yes I feel that way too this should have been

ConstructorInitializer:  Compact

or

ConstructorInitializer:  OnePerLine

It would make


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105099/new/

https://reviews.llvm.org/D105099

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to