ChuanqiXu added a comment. In D95807#2849120 <https://reviews.llvm.org/D95807#2849120>, @lxfind wrote:
> In D95807#2849053 <https://reviews.llvm.org/D95807#2849053>, @aeubanks wrote: > >> this will run the function simplification pipeline twice on every single >> function when coroutines are enabled, I don't think that's the intention >> >> I thought the intention was to do all the the re-adding of SCCs inside >> CoroSplit.cpp, including the SCC with the function that was split > > Good point. I was trying to avoid the second inliner on the coroutine ramp > function. But I guess the cost will be bigger than the win. If coroutine ramp function couldn't get inlined, it would disable coroutine elide optimization. Could you elaborate more on why do you want to do that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95807/new/ https://reviews.llvm.org/D95807 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
