rampitec added inline comments.
================ Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:1245 + +def HasDsSrc2Insts : Predicate<"!Subtarget->hasDsSrc2Insts()">, + AssemblerPredicate<(all_of FeatureDsSrc2Insts)>; ---------------- foad wrote: > The `!` is obviously wrong in this definition, but if I remove it, all the > tests still pass. So does this predicate actually control anything? We don't select these, so only AssemblerPredicate is actually used. This is an obvious typo to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81886/new/ https://reviews.llvm.org/D81886 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
