jdoerfert accepted this revision. jdoerfert added a comment. Looks reasonable to me. We can always refine it as we go.
================ Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:137 +/// * GPUArch (Optional) - Processor name, like gfx906 or sm_30 +/// In presence of Proc, the Triple should contain separator "-" for all +/// standard four components, even if they are empty. ---------------- ================ Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:1263 + + assert(!ArchiveErr); + ---------------- Add a message to asserts. also other places. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93525/new/ https://reviews.llvm.org/D93525 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
