jroelofs added a comment.

Just one question, otherwise LGTM:


================
Comment at: src/UnwindCursor.hpp:580
@@ -579,3 +605,1 @@
       _isSignalFrame(false) {
-  static_assert(sizeof(UnwindCursor<A, R>) < sizeof(unw_cursor_t),
-                "UnwindCursor<> does not fit in unw_cursor_t");
----------------
Is there a good reason to move this static assert out to libunwind.cpp? ISTM it 
serves its purpose better here.


http://reviews.llvm.org/D20119



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to